Redesign #91
Redesign #91
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| return se.tx | ||
| } | ||
|
|
||
| func (se *SipEvent) SetTransaction(tx interfaces.Transaction) { |
There was a problem hiding this comment.
exported method SipEvent.SetTransaction should have comment or be unexported
| se.sipmsg = msg | ||
| } | ||
|
|
||
| func (se *SipEvent) GetTransaction() interfaces.Transaction { |
There was a problem hiding this comment.
exported method SipEvent.GetTransaction should have comment or be unexported
| return se.sipmsg | ||
| } | ||
|
|
||
| func (se *SipEvent) SetSipMessage(msg *message.SipMsg) { |
There was a problem hiding this comment.
exported method SipEvent.SetSipMessage should have comment or be unexported
| } | ||
|
|
||
|
|
||
| func (se * SipEvent) GetSipMessage() *message.SipMsg { |
There was a problem hiding this comment.
exported method SipEvent.GetSipMessage should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type SipEvent struct { |
There was a problem hiding this comment.
exported type SipEvent should have comment or be unexported
| @@ -44,22 +47,22 @@ func (ed *SipStack) CreateListenPoint(protocol string, host string, port int) tr | |||
| return listenpoint | |||
| } | |||
|
|
|||
| func (ed *SipStack) CreateRequestsChannel() chan transaction.Transaction { | |||
| Channel := make(chan transaction.Transaction) | |||
| func (ed *SipStack) CreateRequestsChannel() chan interfaces.Transaction { | |||
There was a problem hiding this comment.
exported method SipStack.CreateRequestsChannel should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type ListeningPoint interface { |
There was a problem hiding this comment.
exported type ListeningPoint should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type SipEventObject interface{ |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| HandleResponses(SipEventObject) | ||
| } | ||
|
|
||
| type Transaction interface { |
There was a problem hiding this comment.
exported type Transaction should have comment or be unexported
| import ("github.com/KalbiProject/Kalbi/sip/message" | ||
| ) | ||
|
|
||
| type SipListener interface { |
There was a problem hiding this comment.
exported type SipListener should have comment or be unexported
| @@ -48,7 +51,7 @@ func (ut *UDPTransport) Start() { | |||
| } | |||
| } | |||
|
|
|||
| func (ut *UDPTransport) SetTransportChannel(channel chan *message.SipMsg) { | |||
| func (ut *UDPTransport) SetTransportChannel(channel chan interfaces.SipEventObject) { | |||
There was a problem hiding this comment.
exported method UDPTransport.SetTransportChannel should have comment or be unexported
| } | ||
| } | ||
|
|
||
| func (tt *TCPTransport) SetTransportChannel(channel chan *message.SipMsg) { |
There was a problem hiding this comment.
exported method TCPTransport.SetTransportChannel should have comment or be unexported
| @@ -29,13 +32,27 @@ func (tt *TCPTransport) Read() *message.SipMsg { | |||
|
|
|||
| } | |||
|
|
|||
| func (tt *TCPTransport) Start() { | |||
There was a problem hiding this comment.
exported method TCPTransport.Start should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type Transaction interface { |
There was a problem hiding this comment.
exported type Transaction should have comment or be unexported
| Send(string, string, string) error | ||
| } | ||
|
|
||
| type SipEventObject interface{ |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| return se.sipmsg | ||
| } | ||
|
|
||
| func (se *SipEvent) SetSipMessage(msg *message.SipMsg) { |
There was a problem hiding this comment.
exported method SipEvent.SetSipMessage should have comment or be unexported
| } | ||
|
|
||
|
|
||
| func (se * SipEvent) GetSipMessage() *message.SipMsg { |
There was a problem hiding this comment.
exported method SipEvent.GetSipMessage should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type SipEvent struct { |
There was a problem hiding this comment.
exported type SipEvent should have comment or be unexported
| GetListeningPoint() ListeningPoint | ||
| } | ||
|
|
||
| type SipEventObject interface{ |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| Send(string, string, string) error | ||
| } | ||
|
|
||
| type Transaction interface { |
There was a problem hiding this comment.
exported type Transaction should have comment or be unexported
No description provided.