go fmt #94
go fmt #94
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
|
|
||
| type SipEventObject interface{ | ||
| type SipEventObject interface { |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| @@ -351,10 +351,11 @@ const FIELD_QOP = 22 | |||
| const FIELD_NONCE = 23 | |||
| const FIELD_REALM = 24 | |||
| const FIELD_ALGORITHM = 25 | |||
| const FIELD_CNONCE = 26 | |||
| const FIELD_CNONCE = 26 | |||
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
exported const FIELD_CNONCE should have comment or be unexported
| } | ||
|
|
||
| func NewContactHeader(){ | ||
| func NewContactHeader() { |
There was a problem hiding this comment.
exported function NewContactHeader should have comment or be unexported
| @@ -1,9 +1,9 @@ | |||
| package message | |||
|
|
|||
| func NewViaHeader(){ | |||
|
|
|||
| func NewViaHeader() { | |||
There was a problem hiding this comment.
exported function NewViaHeader should have comment or be unexported
|
|
||
| func (se * SipEvent) GetSipMessage() *message.SipMsg { | ||
| return se.sipmsg | ||
| func (se *SipEvent) GetSipMessage() *message.SipMsg { |
There was a problem hiding this comment.
exported method SipEvent.GetSipMessage should have comment or be unexported
| } | ||
|
|
||
| type SipEventObject interface{ | ||
| type SipEventObject interface { |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| } | ||
|
|
||
|
|
||
| type SipEventObject interface{ | ||
| type SipEventObject interface { |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| @@ -13,14 +13,13 @@ type ListeningPoint interface { | |||
| Send(string, string, string) error | |||
| } | |||
|
|
|||
| type SipEventObject interface{ | |||
| type SipEventObject interface { | |||
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| @@ -14,20 +13,18 @@ type ListeningPoint interface { | |||
| Send(string, string, string) error | |||
| } | |||
|
|
|||
|
|
|||
| type SipEventObject interface{ | |||
| type SipEventObject interface { | |||
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
| @@ -351,10 +351,11 @@ const FIELD_QOP = 22 | |||
| const FIELD_NONCE = 23 | |||
| const FIELD_REALM = 24 | |||
| const FIELD_ALGORITHM = 25 | |||
| const FIELD_CNONCE = 26 | |||
| const FIELD_CNONCE = 26 | |||
There was a problem hiding this comment.
don't use ALL_CAPS in Go names; use CamelCase
exported const FIELD_CNONCE should have comment or be unexported
| } | ||
|
|
||
| func NewContactHeader(){ | ||
| func NewContactHeader() { |
There was a problem hiding this comment.
exported function NewContactHeader should have comment or be unexported
| @@ -1,9 +1,9 @@ | |||
| package message | |||
|
|
|||
| func NewViaHeader(){ | |||
|
|
|||
| func NewViaHeader() { | |||
There was a problem hiding this comment.
exported function NewViaHeader should have comment or be unexported
|
|
||
| func (se * SipEvent) GetSipMessage() *message.SipMsg { | ||
| return se.sipmsg | ||
| func (se *SipEvent) GetSipMessage() *message.SipMsg { |
There was a problem hiding this comment.
exported method SipEvent.GetSipMessage should have comment or be unexported
| } | ||
|
|
||
| type SipEventObject interface{ | ||
| type SipEventObject interface { |
There was a problem hiding this comment.
exported type SipEventObject should have comment or be unexported
No description provided.