Update message and Utils packages #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: original logic: checked if it wasn't ',' and if wasn't ' ' but ',' isn't ' ' and vice versa New Logic: Checks if byte is in slice of bytes. If not true then criteria met and logic runs. added util function for ContainsByte(). Designed to check if byte is in slice of byte.
hyperioxx
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated message package to correct suspect function and replace logic from #124
NOTE: original logic:
checked if it wasn't ',' and if wasn't ' ' but ',' isn't ' ' and vice versa so criteria was always true.
New Logic:
Checks if byte is in slice of bytes, therefore checking if byte is either of the excepted bytes. If not true then criteria met
and logic runs.
Also added util function and test function for ContainsByte().
Designed to check if byte is in slice of byte.