Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrase element - letter spacing issue #12

Closed
KaliedaRik opened this issue Jan 5, 2021 · 2 comments
Closed

Phrase element - letter spacing issue #12

KaliedaRik opened this issue Jan 5, 2021 · 2 comments
Labels

Comments

@KaliedaRik
Copy link
Owner

When adding letter spacing to a multiline Phrase entity, the spacing applies itself in front of the first letter of the text, both when left-justified and full-justified.

To view the issue, go to demo Canvas 017 and apply letter spacing to the entity.
Screenshot 2021-01-05 at 20 40 37

@KaliedaRik KaliedaRik added the bug label Jan 5, 2021
@KaliedaRik
Copy link
Owner Author

KaliedaRik commented Jan 30, 2021

The above is an artefact of the test, not the library code, caused by the requirement to include a letter - in this case a soft hyphen (& shy ;) at the start of the text to get the initial italic formatting to stick.

Thus the focus of this issue changes from fixing Demo Canvas-017 (which is not broken) to finding out a way to start the Phrase text with a section marker which the code will act on, thus removing the need for clumsy workarounds (such as adding in a soft hyphen at the start of the text)

@KaliedaRik
Copy link
Owner Author

While we're at it, we need to add in right-to-left text support - we have it for text along a path, but not for normal text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant