Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "Server" header to be changed #166

Closed
Kaliumhexacyanoferrat opened this issue Jan 7, 2021 · 0 comments · Fixed by #177
Closed

Allow "Server" header to be changed #166

Kaliumhexacyanoferrat opened this issue Jan 7, 2021 · 0 comments · Fixed by #177
Labels
enhancement New feature or request
Milestone
Version 5.2

Comments

@Kaliumhexacyanoferrat
Copy link
Owner

As a developer of the TechEmpower framework benchmarks, I would like to set the Server header to TFB, so that differences between frameworks due to the length of the header are avoided.

Example

response.Header("Server", "TFB");

Acceptance criteria

  • The server header can be changed if requested
  • The implementation checks for reserved header words, whether they are allowed to be used (e.g. "Date")
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat added the enhancement New feature or request label Jan 7, 2021
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat linked a pull request Jan 18, 2021 that will close this issue
Allow "Server" header to be changed #177
Merged
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat added this to the Version 5.2 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.2
Development

Successfully merging a pull request may close this issue.

Allow "Server" header to be changed Kaliumhexacyanoferrat/GenHTTP
1 participant
@Kaliumhexacyanoferrat