Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer to peer code reveiew #8

Open
2 tasks
divinecharlotte opened this issue Jun 9, 2022 · 0 comments
Open
2 tasks

peer to peer code reveiew #8

divinecharlotte opened this issue Jun 9, 2022 · 0 comments

Comments

@divinecharlotte
Copy link

divinecharlotte commented Jun 9, 2022

Hi @Kamba56,

your code is clean and well separated in modules, Good job so far! clap

There are some issues that you still need to work on but you are almost there!

In order to make your code DRY

  • Please what do you think to save all the localStorage in a function that will make it drier 🤔

  • optional: Check the remove.js file in the module footer 👇 🧐 Let's try to implement the for each instead of for from the sub-array index. This will then follow more ES6 best practices. 👍🏻

for (let i = ind; i < list.length; i += 1) {
list[i].index -= 1;
}

I know you can do it 💪🏻 good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant