Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single spec file same for multiple cell (different Dataframes) visualization #277

Open
rishabh-dream11 opened this issue Oct 21, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rishabh-dream11
Copy link

Issue:
Current functionality does not allow saving different visualizations(different Jupyter cells and different data frames) to a single config file.
If you plan to share your repo with someone for collaboration, this clutters the filespace.

@ObservedObserver
Copy link
Member

Sure, that's a good idea. There might be some small problems about how to design the unique for a cell in juypter to bind the related visualization. @longxiaofei

@ObservedObserver ObservedObserver added the enhancement New feature or request label Oct 21, 2023
@longxiaofei
Copy link
Member

@rishabh-dream11

What do you think of this?

pyg.walker(df, spec="config.json", name="demo0")
pyg.walker(df, spec="config.json", name="demo1")
pyg.walker(df, spec="config.json", name="demo2")

You need to pass in a config path and an instance name at the same time.

The configs of multiple instances are written into the same config file. You use names to distinguish them.

Or

pyg.walker(df, spec="config/demo0.json")
pyg.walker(df, spec="config/demo1.json")
pyg.walker(df, spec="config/demo2.json")

You use a folder to manage your config files.

@rishabh-dream11
Copy link
Author

I would prefer pyg.walker(df, spec="config.json", name="demo0") with an option to give autogenerate a unique keyword for name by itself, which a user can override if they want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants