chore(viznode): Remove usage of the VisualizationNode class #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we're using the VisualizationNode class directly to create a new node as `new VisualizationNode(...)`. This is not a problem itself, but tying entity classes like `KameletBinding` with the `VisualizationNode` class is not ok, as it allows to implement functionality directly on the implementation class that other entities won't leverage. This commit encompass: * Remove the usage of `new VisualizationClass(...)` * Create a new function that returns an instance of `VisualizationNode` but using the `IVisualizationNode` type instead
igarashitm
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some cases, we're using the VisualizationNode class directly to create a new node as
new VisualizationNode(...).This is not a problem itself, but tying entity classes like
KameletBindingwith theVisualizationNodeclass is not ok, as it allows to implement functionality directly on the implementation class that other entities won't leverage.Changes
This commit encompasses:
new VisualizationClass(...)VisualizationNodebut using theIVisualizationNodetype instead