Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new bean modal story #588

Merged
merged 1 commit into from Jan 9, 2024
Merged

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jan 3, 2024

Add storybook story for the new bean modal, which can be now used from the design view for adding new beans.

@lordrip
Copy link
Member

lordrip commented Jan 8, 2024

mmm 🤔 this doesn't seem about right. Also, I don't see any related file being changed that might produce this diff, does this ring a bell to you @tplevko ?

image

@igarashitm
Copy link
Contributor

It seems that broken flow layout has gone after the rebase, possibly it's something not 100% reproducible. I think this PR is not related to that.

@tplevko
Copy link
Contributor Author

tplevko commented Jan 9, 2024

@lordrip this seems really strange - but as @igarashitm wrote, it was probably only random glitch - doesn't seem to be present in the latest chromatic build. I can investigate in case this issue returns

@lordrip
Copy link
Member

lordrip commented Jan 9, 2024

Ah nice, then I'll merge it right away 👌

@lordrip lordrip merged commit ec1cac1 into KaotoIO:main Jan 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants