Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a docker image #602

Merged
merged 1 commit into from Jan 10, 2024
Merged

Provide a docker image #602

merged 1 commit into from Jan 10, 2024

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 8, 2024 •
edited

Description

Please provide a brief summary of your changes along with a link to the related issue if applicable.

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Documentation update
  • Other (please describe)

How Has This Been Tested?

Provide information about the testing procedures, types of tests, and tools used to ensure the functionality and correctness of the changes.

Checklist

  • I have read the Contributing Guidelines.
  • I have followed the coding style and conventions of the project.
  • I have tested my changes and ensured that they work as expected.
  • I have updated any relevant documentation.
  • I have added tests that prove my fix or feature works.

@lburgazzoli
Copy link
Contributor Author

So:

  1. the deploy-to-gh-pages workflow has been renamed to deploy-main
  2. the deploy-main workflow
    • build the ui package
    • publish to gh pages
    • publish to quay

lordrip
lordrip approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the image locally and works great 👍

@lburgazzoli lburgazzoli marked this pull request as ready for review January 10, 2024 09:15
@lordrip lordrip merged commit 04b3dca into KaotoIO:main Jan 10, 2024
10 checks passed
@lburgazzoli lburgazzoli deleted the gh-597 branch January 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lburgazzoli @lordrip