chore(Canvas): Remove Route name restriction #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
chore/remove-name-restrictions
branch
from
1dd7bf2
to
f370b59
Compare
igarashitm
approved these changes
May 3, 2024
|
Are all these patterns working too when deployed with Camel K? Based on previous rule of validation it smells like OpenShift resource id pattern restrictions |
I tried it also in the Developer Sandbox and it worked as well, using the CamelK extension, also the integration name it's the filename |
|
Closing the PR for now, as we need to rework the validation part to apply partially depending on the entity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the route name validator is too strict, whereas Camel JBang accepts route names as:
AnotherRouteMy Route#$%^&$%^This PR disable that validation section.
While keeping the unique ID validation
fix: #968