Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It feels like that name and type in BaseStringL11n sometimes are used for the same purpose #357

Open
spl1nes opened this issue Jan 27, 2024 · 0 comments

Comments

@spl1nes
Copy link
Member

spl1nes commented Jan 27, 2024

File: phpOMS/Localization/BaaseStringL11n.php

Maybe we can always use $type and remove $name.

This would require some smart mapper adjustment where the name is part of the l11n model. Maybe use the path definition in the mapper which is used by arrays (e.g. type/name).

More maybe: $name might have been intended as internal value? -> Makes no sense because only string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant