Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The on part of a join doesn't allow string values because they conflict with column names #369

Open
spl1nes opened this issue Feb 2, 2024 · 0 comments

Comments

@spl1nes
Copy link
Member

spl1nes commented Feb 2, 2024

File: phpOMS/DataStorage/Database/Query/Grammar/Grammar.php

if (isset($element['value'])) {
  $expression .= ' ' . \strtoupper($element['operator']) . ' '
      . (\is_string($element['value']) ? $this->compileSystem($element['value']) : $element['value']);
}

Other data types are possible because they don't conflict with the data type of columns (string)
Consider to create a ColumnName() class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant