New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the SingleSelect menu for when hideOptionsWhenSelect is True #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or issue of after it collapses upon selection
…rcumvent confusion
…CollapseMenu method
KarimEbrahemAbdelaziz
added
bug
Something isn't working
enhancement
New feature or request
labels
Feb 17, 2021
Is there anything that needs work on this in particular @KarimEbrahemAbdelaziz |
…le of its use in the example project
Henry c menu dismiss
Hi @KitsuneNoctus , What an amazing PR 🔥 I need to make 2 changes to this PR to be able to merge it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR - pt. 1
There was an issue in which when
isMultiSelect
is set to false andhideOptionsWhenSelect
is set to true that the menu would drop down for a selection, would allow for selection. When an item is selected, the menu will then collapse as it should.The issue came when I would come to expand the menu again that it would not drop down on the initial touch interaction, though the arrow indicating the current state of the menu would animate. Upon pressing it a second time the menu would expand. This bug occurred every time after a selection was made. Nothing would be broken, but it was a simple style issue that would cause users to slow down and such.
The issue seemed to be that when a selection was made, the toggle method that switched the SwiftyMenuState would not trigger for some reason.
The change that needed to be made was at lines 299, 309, 315, and 325. I simply changed it from calling the method
collapseSwiftyMenu()
to the methodhandleMenuState()
in order to trigger the toggle.Fixes # 1
Type of change
How Has This Been Tested?
This was tested via a simple user testing method in which I would update the pods on the example project and run the project to test if the menu was still having the same issues after the changes were made.
Test Configuration:
Checklist:
PR - pt. 2
Created a changes based on the list of TODO's on the main project page. Attempted to create a change where the menu would close when you would tap on the parent view, but could not get touches out of the menu to be recognized. Then went to attempt at making a user friendly method for separator styling. It can edit color, visibility, and blur effects so far.
Type of change
How Has This Been Tested?
Using the simulator and adding and example of the method to the example project. Tested over and over again to try and get different effects. What is pushed now is what I could achieve in the time frame.
Test Configuration:
Checklist:
PR Issue
The issue with the build is something I attempted to remedy by installing more versions of the os, but this did not seem to remedy the issue at hand.