Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test to ensure Peak RSS is being reported #72

Open
zakkak opened this issue Dec 10, 2021 · 6 comments
Open

Create test to ensure Peak RSS is being reported #72

zakkak opened this issue Dec 10, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@zakkak
Copy link
Collaborator

zakkak commented Dec 10, 2021

With the new native-image output Peak RSS is also reported.

We should implement a test that would ensure Peak RSS is indeed reported (see graalvm/mandrel-packaging#211)

@zakkak zakkak added the enhancement New feature or request label Dec 10, 2021
@jerboaa
Copy link
Collaborator

jerboaa commented Dec 10, 2021

+1

@fniephaus
Copy link

Any way you could contribute such a test upstream?

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 22, 2021

Any way you could contribute such a test upstream?

Sure, especially if you can point us to some existing upstream test checking the compilation output.

@fniephaus
Copy link

Sure, especially if you can point us to some existing upstream test checking the compilation output.

I'm afraid we don't have any tests for the new output (yet).

@zakkak
Copy link
Collaborator Author

zakkak commented Jan 4, 2022

I'm afraid we don't have any tests for the new output (yet).

@fniephaus I meant "any" test checking the compilation output, e.g., it could be some testing checking to see if a warning was thrown etc. If there is no such tests already in place we should discuss this upstream to see how we should implement it (e.g. let mx generate temp files and grep them? Create junit tests that run native-image and check the output? etc.).

@fniephaus
Copy link

I'm afraid I haven't seen any such tests. I don't think it makes sense to unit-test the reporter but I also have no idea how to check all possible or at least most error cases that can happen in Native Image. Of course, we could start with something simple. I just haven't had the chance to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants