Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark variables as const where appropriate #9

Open
Miepee opened this issue Feb 15, 2022 · 2 comments
Open

Mark variables as const where appropriate #9

Miepee opened this issue Feb 15, 2022 · 2 comments

Comments

@Miepee
Copy link
Contributor

Miepee commented Feb 15, 2022

Variables like cfgFile or cfgKeysFile should be marked as constants, as these are never expected to change.

@Miepee Miepee mentioned this issue Feb 20, 2022
@Miepee
Copy link
Contributor Author

Miepee commented Feb 26, 2022

Partly addressed by #11 but not completely fixed yet.
There are still a bunch of variables that either a) should not be global or b) should be marked as constants.

@KarstSkarn
Copy link
Owner

Hello there! I did update the whole program today. I've been loosely working on it in my spare free time. I did include many things from your Huge Refactoring branch and fixed many of the "TO DO" you did write there. I also mentioned in the $Credit command inside the program (Just a thanks to you and your GitHub URL). If you have some spare time I invite you to take a look to it.

I didn't keep the files separated since the original source I kept working on it was the original old one. But I did manually upgrade some of your parts into there! @Miepee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants