Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On startup the heater target temperature is used without checking for calibration_type == 0 #75

Closed
Cycor opened this issue Dec 6, 2021 · 1 comment · Fixed by #80
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@Cycor
Copy link
Contributor

Cycor commented Dec 6, 2021

When I restart home assistant all the set temperatures are off because it takes the value from the real climate instance without checking for the calibration_type

self._target_temp = float(self.hass.states.get(self.heater_entity_id).attributes.get('current_heating_setpoint'))

--

in the same vein, could we get an option to disable _async_tvr_changed, I have no use for reverse syncing the valve states, it just causes weird issues.

Another thing, the window close 'converted_hvac_mode = self.beforeClosed' will be fired every time async_control_heating is called because beforeClosed is never reset to OFF

And a small request, can we get a is_device_active based on the valve position, it's nice to see idle/heating when it is actually doing something.
my tweak:

        valve = self.hass.states.get(self.heater_entity_id).attributes.get('position')
        if check_float(valve):
            valve = float(valve)
        else:
            valve = 101
...
        elif state_heat:
            return state_heat and (valve > 0)
        elif state_auto:
            return state_auto and (valve > 0)

ps. If you are really bored, can you add self._name to all log lines, I update those every update so I can debug easier.

@KartoffelToby KartoffelToby added the bug Something isn't working label Dec 6, 2021
@KartoffelToby KartoffelToby linked a pull request Dec 6, 2021 that will close this issue
@KartoffelToby KartoffelToby removed a link to a pull request Dec 6, 2021
@KartoffelToby
Copy link
Owner

@Cycor
I removed the PR linking, because you address 2 Issues here, the target temp checking on startup is fixed by 0.7.9

Your request make sense but it will be a problem for TRVs who does have a valve state or call it valve_position

So yes, i will implement this in 0.8.0 but only for valve reporting TRVs

Thanks (keep it open until 0.8.0)

@KartoffelToby KartoffelToby added the enhancement New feature or request label Dec 6, 2021
@KartoffelToby KartoffelToby linked a pull request Dec 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants