Create base tests #1
Conversation
|
|
||
| RecyclerViewInteraction.onRecyclerView<SuperHero>(withId(R.id.recycler_view)) | ||
| .withItems(superHeroes) | ||
| .check({ (name), view, e -> matches(hasDescendant(withText(name))).check(view, e) }) |
There was a problem hiding this comment.
I like use exception instead e, but it is not important.
|
|
||
| RecyclerViewInteraction.onRecyclerView<SuperHero>(withId(R.id.recycler_view)) | ||
| .withItems(superHeroes) | ||
| .check({ (name), view, e -> matches(hasDescendant(withText(name))).check(view, e) }) |
There was a problem hiding this comment.
why is name between parenthesis?
There was a problem hiding this comment.
Just a neat trick: https://kotlinlang.org/docs/reference/multi-declarations.html
We are basically destructuring the data class: (name, photo, isAvenger, description) ~=[iff 3 last properties are ignored] (name, _, _, _) ~= (name)
|
|
||
| @Test | ||
| fun doesNotShowAvengersBadgeIfASuperHeroIsNotPartOfTheAvengersTeam() { | ||
| val superHeroes = givenThereAreSomeSuperHeroes(ANY_NUMBER_OF_SUPER_HEROES, false) |
There was a problem hiding this comment.
by default is false no? you don't need set this false arg.
There was a problem hiding this comment.
It is the default value, we are just making it explicit what we want. To me, removing the flag would mean we don't really care if they are avengers or not (I'm adding a name to the parameter to make that clear though)
| } | ||
|
|
||
| private fun givenThereAreSomeAvengers(numberOfAvengers: Int): List<SuperHero> = | ||
| givenThereAreSomeSuperHeroes(numberOfAvengers, true) |
There was a problem hiding this comment.
if I didn't remember bad in the screenshot tests, you use named arguments, like avengers = true. should be a good idea if we make it too?
There was a problem hiding this comment.
Yeah, I'm going to make it explicit here too, good catch! 👌
|
|
||
| private fun givenThereAreSomeSuperHeroes(numberOfSuperHeroes: Int = ANY_NUMBER_OF_SUPER_HEROES, avengers: Boolean = false): List<SuperHero> { | ||
| val superHeroes = LinkedList<SuperHero>() | ||
| for (i in 0 until numberOfSuperHeroes) { |
There was a problem hiding this comment.
in screenshot superhero we used IntRange(0, numberOfSuperHeroes - 1).map { id -> /**/} instead the for, I don't konw if you llike it or not. I more or less de same, but more kotlin stye.
| on(repository.getAllSuperHeroes()).thenReturn(emptyList<SuperHero>()) | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
are we going to add companion objects in the top of the class or in the bottom?
There was a problem hiding this comment.
Let's keep it at the top of the classes just because 👍
|
|
||
| @After | ||
| fun tearDown() { | ||
| val idlingResources = IdlingRegistry.getInstance().resources |
|
|
||
| @Test | ||
| fun doesNotShowAvengersBadgeIfSuperHeroIsNotPartOfTheAvengersTeam() { | ||
| val superHero = givenThereIsASuperHero(false) |
There was a problem hiding this comment.
do you prefer use named arguments?
| } | ||
|
|
||
| fun check(assertion: (item: A, view: View, e: NoMatchingViewException?) -> Unit): RecyclerViewInteraction<A> { | ||
| for (i in items.indices) { |
There was a problem hiding this comment.
and use iitems.indices.forEach ??
| return this | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
the same questions about companion objects, only for define a standard :)
…oks like it's inclusive :P
Serchinastico
force-pushed
the
create-tests
branch
from
117cf0a
to
9c1d426
Compare
🌀 Git merge message