Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive check button #3

Merged
merged 8 commits into from Oct 8, 2022
Merged

Interactive check button #3

merged 8 commits into from Oct 8, 2022

Conversation

Kasaija-Kenneth
Copy link
Owner

  • Implement a function for adding a new task
  • Implement a function for editing a task
  • Implement a function for deleting a task
  • All changes to the To Do List should be saved in local storage
  • Add interactive check buttons
  • Add event listener to the checkbox (change).
  • Implement a function for the "Clear all completed" button (use filter() method).

Copy link

@franclobo franclobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kasaija-Kenneth,

STATUS : APPROVED 😃

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✔️
  • Correct Github flow ✔️
  • Descriptive PR ✔️
  • Professional README file ✔️

Optional suggestions

  • [OPTIONAL] Althogh your project is approved you are not going to be able to merge it until you solve it: 👇🏽

image

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Kasaija-Kenneth
Copy link
Owner Author

All changes actioned as recommended by the code reviewer

@Kasaija-Kenneth Kasaija-Kenneth merged commit 47e5892 into main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants