Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #30087 - allow candlepin to bind port 23443 #29

Merged
merged 1 commit into from Aug 25, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jul 27, 2020

This includes #26 with the added require on tomcat_t.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird to have a candlepin policy in katello-selinux and suggests that you need to have katello-selinux installed to run candlepin. Shouldn't this be in the candlepin policy?

@ehelms
Copy link
Member Author

ehelms commented Jul 31, 2020

Our project is the one choosing to deploy Candlepin onto the 23443 port. Therefore it falls to us to configure SELinux rather than asking Candlepin to manage every non-standard port. This is a follow up to 85e372a

@ekohl
Copy link
Member

ekohl commented Jul 31, 2020

Yes, but it implies that if I want to deploy candlepin on a server, I need to install katello-selinux, or install Candlepin on port 8443?

@ehelms
Copy link
Member Author

ehelms commented Jul 31, 2020 via email

@evgeni
Copy link
Member

evgeni commented Aug 5, 2020

IMHO having this in katello-selinux is fine, as the port is a specific of the katello deployment

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah overlook from my side, all types must be required...

@ehelms ehelms merged commit f197044 into theforeman:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants