Refs #7224 - initial pass at making puppet-candlepin work for hosted environment #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any further concerns with this change? |
|
@dcrissman I need to run it through our installer tests to ensure it doesn't break anything. Do you think some spec tests here would benefit to ensure this doesn't break in the future? |
|
I am not opposed to writing spec tests for this change. |
|
@ehelms spec tests have been added. Please review when you have a change. |
|
@dcrissman This passed for me testing against our katello-installer setup so I am going to ACK and merge. Thanks for your patience and the work! |
ehelms
added a commit
that referenced
this pull request
Oct 28, 2014
Refs #7224 - initial pass at making puppet-candlepin work for hosted environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #10.
This PR is an initial change to move the puppet-candlepin module closer to being able to be reusable for hosted candlepin.