Re-factor to Candlepin default configuration

[ehelms]

This also removes direct references to the puppet-certs module and
allows more customization of Candlepin configuration. Note as well,
this changes the values of some configuration to match Candlepin
defaults and those values will need to be set explicitly by other
modules.

[ehelms]

@stbenjam I assume this will need a major version rev since I am changing the default configuration?

[ehelms]

@mstead @awood Would you mind reviewing these changes as they relate to how Candlepin is deployed by default? My goal here is that you should be able to stand up a 'standard' Candlepin server with this puppet module.

[awood]

Looks good to me!

[mstead]

ACK. Same here. Nothing stands out to me.

[ehelms]

@stbenjam mind weighing in on my question above before we merge this?

[stbenjam]

Crazy nitpicky, but standardize on one kind of quotes, and either one space or aligned indentation the values

[stbenjam]

Just a few nitpicks.

Re: your question, The class params stay the same, just defaults change. I think the minor might be fine? I'm not really sure though.

[ehelms]

@stbenjam addressed all comments

[ehelms]

I had to make some changes to the candlepin.conf template in order for tests to pass

[stbenjam]

Did you want to bump the version in metadata.json? It's still also only 0.x so I think you could just do 0.2.0 regardless but I'll leave it up to you.

ACK from me

[ehelms]

Good point, and yea I think I'll keep it at 0.2.0 because you currently cannot use this as is to setup a full Candlepin. There is the issue of database migrations and certificate handling that needs addressing.