Adding specification of CA cert, key and password to the Candlepin #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,10 @@ | |||
| $thumbslug_oauth_key = 'thumbslug' | |||
| $thumbslug_oauth_secret = 'thumbslug' | |||
|
|
|||
| $ca_key = '/etc/candlepin/certs/candlepin-ca.key' | |||
| $ca_cert = '/etc/candlepin/certs/candlepin-ca.crt' | |||
| $ca_key_password = 'candlepin' | |||
There was a problem hiding this comment.
could we use cache_data('candlepin_ca_password', random_password(32)) instead?
There was a problem hiding this comment.
I'll set it to undef, since in this context the ca_key_password parameter doesn't make any sense and would need to be passed in from an external source.
configuration file.
|
@iNecas updated |
|
ACK |
ehelms
added a commit
that referenced
this pull request
Mar 7, 2014
Adding specification of CA cert, key and password to the Candlepin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration file.