Add optional repository management #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Mar 29, 2017
manifests/init.pp
Outdated
| # $manage_repo:: Whether to manage the yum repository | ||
| # type:Boolean | ||
| # | ||
| # $repo:: Which yum repository to install. For example latest or 3.3 |
There was a problem hiding this comment.
This will be a little strange for users of this module given its the Katello version to be specified and not the Candlepin version (and not necessarily obvious unless we rename the parameter).
There was a problem hiding this comment.
Should I add a 'note that this is the katello version'?
|
Overall looks good. |
|
Updated |
ehelms
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.