Update Candlepin configuration #9
Conversation
| @@ -16,6 +16,8 @@ | |||
|
|
|||
| # this comes from keystore | |||
| $db_password = cache_data('candlepin_db_password', random_password(32)) | |||
| $amqp_keystore_password = $::certs::candlepin::keystore_password | |||
| $amqp_truststore_password = $::certs::candlepin::keystore_password | |||
There was a problem hiding this comment.
I would define these two in init.pp unless you plan to allow them to be set via parameters.
There was a problem hiding this comment.
If I would like them to be settable via parameters, what changes would I need to make? I think it would be nice if people could configure the keystore/truststore passwords if they wished.
There was a problem hiding this comment.
Look at https://github.com/Katello/puppet-candlepin/pull/9/files#diff-60ae41fd0a31977447947f59940ee9a4L53 those are all configurable parameters that have defaults set by the params.pp file. Also note documentation above for each parameter.
There was a problem hiding this comment.
This also means you can break your reliance on the certs module here, and pass that information in when the Candlepin module is delcared if you want.
|
ACK. Thanks @awood |
Refs #6418