Refs #10616 - use new pulp child ssl fragment for gpg key proxy #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires theforeman/puppet-pulp#66 |
|
What do you think about a test that ensures this gets called with this content file if $pulp is true? |
|
@ehelms added test, not sure how to test the content, as it is a rendered template as a param value, any thoughts? |
| @@ -45,6 +45,8 @@ | |||
|
|
|||
| it { should contain_class('crane').with( {'key' => '/etc/pki/katello/private/katello-apache.key', | |||
| 'cert' => '/etc/pki/katello/certs/katello-apache.crt'} ) } | |||
|
|
|||
| it { should contain_pulp__child__fragment('gpg_key_proxy') } | |||
There was a problem hiding this comment.
I think you can do with here:
it 'should contain pulp gpg proxy' do
should contain_pulp_child_fragment('gpg_key_proxy').with({
:ssl_content => template('capsule/_pulp_child_gpg_proxy.erb'
})
end
|
@ehelms updated |
|
ACK |
jlsherrill
added a commit
that referenced
this pull request
Jun 1, 2015
Refs #10616 - use new pulp child ssl fragment for gpg key proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.