Fixes #13199 - change pulp_parent to qpid_client #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpmitsch
changed the title
|
[test] |
|
This requires theforeman/puppet-certs#78 |
|
I ran foreman-installer --scenario katello on an existing box with this and the certs PR changes (mentioned above) and the installer ran fine except for a seed error that I am pretty sure we already know about and is unrelated. I was able to create and sync a repo as well. |
johnpmitsch
force-pushed
the
pulp_parent
branch
from
43786e8
to
8611105
Compare
johnpmitsch
changed the title
| class { '::pulp': | ||
| oauth_enabled => true, | ||
| oauth_key => $katello::oauth_key, | ||
| oauth_secret => $katello::oauth_secret, | ||
| messaging_url => "ssl://${::fqdn}:5671", | ||
| messaging_ca_cert => $certs::pulp_parent::messaging_ca_cert, | ||
| messaging_client_cert => $certs::pulp_parent::messaging_client_cert, | ||
| messaging_ca_cert => $certs::qpid_client::messaging_ca_cert, |
There was a problem hiding this comment.
This should just be $::certs::ca_cert now.
johnpmitsch
force-pushed
the
pulp_parent
branch
from
8611105
to
070bd56
Compare
|
@ehelms updated |
|
@ehelms I'm not sure how to fix these broken tests, are there fixture files? |
|
I think once theforeman/puppet-certs#78 gets merged your tests should pass |
|
Can you please update the minimum here to 0.5.0 -- https://github.com/Katello/puppet-katello/blob/master/metadata.json#L37 |
johnpmitsch
force-pushed
the
pulp_parent
branch
from
070bd56
to
06e9dd8
Compare
|
@ehelms updated |
|
Thanks @johnpmitsch ! |
ehelms
added a commit
that referenced
this pull request
Mar 16, 2016
Fixes #13199 - change pulp_parent to qpid_client
jlsherrill
added a commit
to jlsherrill/puppet-katello_devel
that referenced
this pull request
Mar 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.