Improve ownership and remove unused code #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point the bundler file was ensured to be owned by the katello user. This traces back to the start of the module (ae7d4aa) but there is no real reason for this. We could not manage the file at all, but by ensuring it's owned by root we improve security for existing users. We also tighten the ownership on the katello.yaml config file.
These are unused since 5687ce1.
Merged
|
Restarted puppet 4 builds due to other PRs being merged. They should pass now. |
|
ACK - thanks @ekohl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the bundler file was ensured to be owned by the katello user. This traces back to the start of the module (ae7d4aa) but there is no real reason for this. We could not manage the file at all, but by ensuring it's owned by root we improve security for existing users.
We also tighten the ownership on the katello.yaml config file.
It removes the remains of client.conf which are unused since 5687ce1.