Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crane_data_dir #193

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Remove crane_data_dir #193

merged 1 commit into from
Jun 6, 2017

Conversation

jlsherrill
Copy link
Contributor

as it should be handled by foreman_proxy_content, that pulls
in crane.

@jlsherrill
Remove crane_data_dir
3d3839e 
as it should be handled by foreman_proxy_content, that pulls
in crane.
ehelms
ehelms approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially since we don't pass enable_crane this parameter here does nothing.

@jlsherrill jlsherrill merged commit e1cfe1c into theforeman:master Jun 6, 2017
@jlsherrill jlsherrill deleted the crane_data branch June 6, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlsherrill @ekohl @ehelms