Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20518 - set pulp tasks to 2 #203

Merged
merged 1 commit into from Aug 10, 2017
Merged

Fixes #20518 - set pulp tasks to 2 #203

merged 1 commit into from Aug 10, 2017

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Aug 9, 2017

Downstream this change was made for performance reasons, reference in the following BZ:

https://bugzilla.redhat.com/show_bug.cgi?id=1388631

@ekohl
Copy link
Member

ekohl commented Aug 9, 2017

Where does the number 2 come from? Setting this 2 also means the text (from the bugzilla) "To disable this completely, users can set '--katello-max-tasks-per-pulp-worker' to 'undef'." needs to be changed to to '0'.

@chris1984
Copy link
Member Author

chris1984 commented Aug 9, 2017

@ekohl it comes from https://bugzilla.redhat.com/show_bug.cgi?id=1388631#c19 I can let @beav comment more on this why the change was made as he was doing the perf stuff. in 6.2 its set to 2 and needs to be set to 2 for 6.3/upstream.

@beav
Copy link
Contributor

beav commented Aug 9, 2017

There is nothing special about the number 2, I think the pulp team settled on it after testing and noticing that it's extremely cheap to shut down and spin up a new worker process, so it's done after every other task. You could probably pick another small number and it would work similarly but 2 is the convention. I've never seen issues with 2, but I would most likely say the same if it was any other reasonably small number 😸

@ehelms ehelms merged commit cdf19a1 into theforeman:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants