Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8444 - Expose cdn_ssl_version as an installer #51

Merged
merged 1 commit into from
Dec 10, 2014

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Dec 4, 2014

$ katello-installer --help | grep cdn-ssl

--katello-cdn-ssl-version SSL version used to communicate with the
CDN. Optional. Use SSLv23 or TLSv1 (default: nil)

$ katello-installer --katello-cdn-ssl-version=TLSv1
will add the following to /etc/foreman/plugins/katello.yaml

common:
cdn_ssl_version: TLSv1

@@ -0,0 +1,29 @@
require 'spec_helper'

describe 'katello' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be katello::config

@parthaa parthaa force-pushed the cdn-ssl branch 2 times, most recently from 3f73ea8 to ce9c193 Compare December 4, 2014 23:59
:operatingsystemrelease => '6.5',
}
end
context 'default config settings' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick empty line to separate logic blocks.

$ katello-installer --help | grep cdn-ssl

  --katello-cdn-ssl-version     SSL version used to communicate with the
CDN. Optional. Use SSLv23 or TLSv1 (default: nil)

$ katello-installer  --katello-cdn-ssl-version=TLSv1
will add the following to /etc/foreman/plugins/katello.yaml

common:
  cdn_ssl_version: TLSv1
@ehelms
Copy link
Member

ehelms commented Dec 10, 2014

ACK

parthaa added a commit that referenced this pull request Dec 10, 2014
Fixes #8444 - Expose cdn_ssl_version as an installer
@parthaa parthaa merged commit d968091 into theforeman:master Dec 10, 2014
@parthaa parthaa deleted the cdn-ssl branch December 10, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants