Ref #9055 - make packages depended on, a configurable parameter #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package { $katello::package_names: | ||
| ensure => installed, | ||
|
|
||
| if $katello::packages == undef { |
There was a problem hiding this comment.
You can also solve this using pick:
$packages = pick($katello::packages, $katello::package_names)
package { $packages:
ensure => installed,
}
dustints
force-pushed
the
packages_option
branch
from
0b443ad
to
cd14ceb
Compare
|
@ekohl addressed...just expose package_names as a parameter |
|
👍 pending tests. |
|
@ehelms saw your comment in Katello/katello#4923. |
|
I want to say yes, but I have been intentionally testing the entire stack and process to ensure that all proposed changes solve the problem. |
|
ACK |
| @@ -54,6 +56,8 @@ | |||
| $proxy_username = $katello::params::proxy_username, | |||
| $proxy_password = $katello::params::proxy_password, | |||
| $cdn_ssl_version = $katello::params::cdn_ssl_version, | |||
|
|
|||
| $package_names = $katello::params::package_names | |||
There was a problem hiding this comment.
Nitpick: I tend to prefer trailing commas because they lead to smaller differs.
There was a problem hiding this comment.
@dustints you might have forgot to push your changes
There was a problem hiding this comment.
@ehelms darn! yah that was the case...ok pushed this time.
dustints
force-pushed
the
packages_option
branch
from
cd14ceb
to
4193c3c
Compare
|
APT |
|
👍 |
dustints
pushed a commit
that referenced
this pull request
Jan 26, 2015
Ref #9055 - make packages depended on, a configurable parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.