refs #9060 - configure qpid::client with params #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stbenjam what about a basic test to ensure this client is called with this config? |
|
Here's a test. I think the test is of dubious value, I always feel wrong pulling variables across namespaces (e.g. pulling certs values from katello), but I'm not enough of a puppet-y person to know if my instinct is right... and I'm not sure how to get at the values in rspec to test for all the parameters. Any idea? Regardlesss, the habit of writing/asking for tests is at least good 👍 |
|
ACK |
stbenjam
added a commit
that referenced
this pull request
Feb 6, 2015
refs #9060 - configure qpid::client with params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters for configuring the client, needed for the changes that happened in theforeman/puppet-qpid#12