Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 7802 - ensure that qpidd and user and group are created #11

Merged
merged 1 commit into from Oct 24, 2014

Conversation

dustints
Copy link

class qpid::config {
class qpid::config (
$user = $qpid::params::user,
$group = $qpid::params::group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not likely to be used outside of the qpid module itself, we might as well place these as params on init.pp or not as params at all (and leave them unconfigurable by a user)

@dustints
Copy link
Author

@ehelms updated, moved user and group to init.pp

@ehelms
Copy link
Member

ehelms commented Oct 24, 2014

@dustints I simplified this locally and tested our installer and everything was good:

diff --git a/manifests/config.pp b/manifests/config.pp
index 2c90654..c45237e 100644
--- a/manifests/config.pp
+++ b/manifests/config.pp
@@ -4,7 +4,10 @@
 #
 class qpid::config {

-  user { 'qpidd':
+  group { $qpid::group:
+    ensure => present
+  } ->
+  user { $qpid::user:
     ensure => present,
     groups => [$qpid::user_groups],
   }
diff --git a/manifests/params.pp b/manifests/params.pp
index 674999b..a4be807 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -9,4 +9,7 @@ class qpid::params {

   $user_groups = []

+  $user = 'qpidd'
+  $group = 'qpidd'
+
 }

@dustints
Copy link
Author

@ehelms updated with patch

@ehelms
Copy link
Member

ehelms commented Oct 24, 2014

ACK

dustints pushed a commit that referenced this pull request Oct 24, 2014
Fixes 7802 - ensure that qpidd and user and group are created
@dustints dustints merged commit 737c5c9 into theforeman:master Oct 24, 2014
@dustints dustints deleted the 7802_user_qpidd_group branch October 24, 2014 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants