Refs #19929 - Add wcache-page-size to installer #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
requested changes
Jun 5, 2017
manifests/init.pp
Outdated
| @@ -28,6 +28,8 @@ | |||
| # | |||
| # $max_connections:: Maximum number of connections to allow | |||
| # | |||
| # $wcache_size:: The size (in KB) of the pages in the write page cache | |||
There was a problem hiding this comment.
Since the config parameter is named wcache_page_size can we call this parameter the same for 1:1 mapping? Leaves no room for guess work :)
|
@ehelms updated with wcache_page_size for var name, if you can review again please. |
ehelms
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.