Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ArgumentType with abstract ArgumentTypeInfo in Descriptor #56

Closed
KathleenDollard opened this issue Jun 1, 2020 · 0 comments · Fixed by #58
Closed

Replace ArgumentType with abstract ArgumentTypeInfo in Descriptor #56

KathleenDollard opened this issue Jun 1, 2020 · 0 comments · Fixed by #58

Comments

@KathleenDollard
Copy link
Owner

ArgumentType is problematic because we don't actually know how the ArgumentType is best represented in the Specific layer, and it must be retrieved via the specific layer (as is done with Reflection). The Type type is actually a Reflection construct, invalid in JSON and probably invalid in Roslyn.

The ArgumentTypeInfo class has the goal of having both a general and a specific way to identify the class. In practice, we anticipate Reflection->Runtime types and Roslyn->Source generation without those streams crossing, and JSON is an intellectual exercise for the present. So it seems silly to force the type into a general format and back again - since that format can't be any better than a string name, with associated hassles about how full of a name to use.

There are a few gnarly details still to work out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant