Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SliverFlexibleHeader proposal #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcoredz
Copy link

@marcoredz marcoredz commented Oct 22, 2022

This new widget should allows to create a Sliver header that can be pinned or floating based on a parameter without knowing the size of its child.

Demo:

sliver_flexible_header.mp4

@JasCodes
Copy link

JasCodes commented Dec 4, 2022

@Kavantix Whats holding this back?

@JasCodes
Copy link

JasCodes commented Dec 4, 2022

@marcoredz Doesn't work in Sliver Stack btw

cc @Kavantix

@Kavantix
Copy link
Owner

Kavantix commented Feb 1, 2023

@marcoredz sorry for the late reply, have been swamped again.
But thanks for the contribution!
In general the implementation looks good although I'm not sure if it handles the overlap correctly in all cases.
Could you add some tests for a few simple cases and some overlap cases.

For the API of the package it would make more sense to have a SliverFloatingHeader widget that is always floating since there is already a SliverPinnedHeader

Copy link
Owner

@Kavantix Kavantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for a few simple cases and some overlap cases.

For the API of the package it would make more sense to have a SliverFloatingHeader widget that is always floating since there is already a SliverPinnedHeader

@marcoredz
Copy link
Author

marcoredz commented Jun 13, 2023

Apologies for the delayed response, @Kavantix. My proposal was based on this gist: https://gist.github.com/tomaszpolanski/cf0edb7961d2304c2f293da9971cd4c9.

Unfortunately, I am currently unable to proceed with working on this proposal. Therefore, if you or someone else can find a way to incorporate this feature into the package, it would be awesome. Otherwise, it's not a problem for me if you decide to close the PR.

Edit: I totally agree with your API naming suggestion and functionality, so the floating parameter could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants