Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe state with delegate #15

Closed
0xch4z opened this issue Feb 11, 2018 · 2 comments
Closed

Observe state with delegate #15

0xch4z opened this issue Feb 11, 2018 · 2 comments

Comments

@0xch4z
Copy link
Contributor

0xch4z commented Feb 11, 2018

Thanks for the library! It would be cool if there was a delegate protocol to preform actions on the drawer state changing rather than having to pass a completion handler in. For example, the following stubs:

func drawerController?(willOpenSide side: DrawerSide)

func drawerController?(willCloseSide side: DrawerSide)

I'd be happy to submit a PR.

Thanks,
Charles

@kawoou
Copy link
Owner

kawoou commented Feb 12, 2018

Sounds like a good idea😆
Do I add this? Or if you would like to upload your own PR, I'll be happy to review.

@0xch4z
Copy link
Contributor Author

0xch4z commented Feb 13, 2018

Sweet, thanks. Just added PR #16. Already using this in my own project and it's a big help for changing the status bar color when the drawer is open.

Let me know if I need to change anything!

@0xch4z 0xch4z closed this as completed Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants