Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Profile Language and Birthday Type Declarations #37

Open
bryceremick opened this issue Oct 14, 2020 · 0 comments
Open

Change Profile Language and Birthday Type Declarations #37

bryceremick opened this issue Oct 14, 2020 · 0 comments
Labels
Priority: Medium 🐢 Type: Enhancement ✨

Comments

@bryceremick
Copy link
Member

bryceremick commented Oct 14, 2020 •
edited

  • profile.birthday is typed as a string and is ambiguous. It makes more sense for it to be Date type and have the SDK convert the date into the correct string format when needed for requests.

  • profile.language is also ambiguously typed as a string. Enum for the languages we currently support?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium 🐢 Type: Enhancement ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bayssmekanique @bryceremick