Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting shows only total amount of deducted time #8

Closed
Does-This-Work opened this issue May 24, 2023 · 10 comments
Closed

Reporting shows only total amount of deducted time #8

Does-This-Work opened this issue May 24, 2023 · 10 comments

Comments

@Does-This-Work
Copy link

It would be great, if under Reporting the deducted time, would also be displayed under the day.
Right now I can only see how much time I spend in total on breaks but I cannot see, how long my break was for a certain day.

Working Hours Total Day 1 Day 2 Day 3 Day 4 Day 5
Working 40 9 7 8 8 8
Breaks -5
Working Hours Total 35 8 6 7 7 7
@kevinpapst
Copy link
Member

What screen is that?

@Does-This-Work
Copy link
Author

The screen is located under
/reporting/user/week
/reporting/user/month
/reporting/user/year
grafik

@kevinpapst
Copy link
Member

kevinpapst commented May 25, 2023

Bildschirmfoto 2023-05-25 um 10 37 46

Maybe you have to upgrade to the latest Kimai release?

@Does-This-Work
Copy link
Author

Running Kimai: 2.0.23
Plugin Version: 2.0.1

Anything that I maybe misconfigured with the plugin? This is how I configured the break activity
grafik

User View
grafik

Admin View
grafik

@kevinpapst
Copy link
Member

Strange... I can't see any cause for that, sorry 🤷

@Does-This-Work
Copy link
Author

Okay! Thanks for taking the time, to look at this issue

@kevinpapst
Copy link
Member

Can you share the actual timesheet as well please. What you show doesn't really make sense.
Afair there is no check that hides negative times in this screen, so I do not understand how this can happen.

@Does-This-Work
Copy link
Author

Does-This-Work commented May 26, 2023

Of course! I added some extra data. I also saw, that I made a mistake in the earlier screenshot.
I hope the new screenshots can tell you more

grafik

grafik

Thank you for your help! 👍

EDIT: I also tried reinstalling the plugin but that didn't do anything...

@stephan-senkbeil
Copy link

I just came across the same issue using this plugin.
I tracked this down to the twig template for the reports in which activities with a negative duration are excluded (https://github.com/kimai/kimai/blob/e98732f44a75b60a53a9a55e5a9d1b890e473526/templates/reporting/report_by_user_data.html.twig#L106).

Changing column.duration > 0 to e.g. column.duration != 0 fixes this issue but I haven't checked if anything else breaks with this change as I'm not at all familiar with the Kimai code base.

@kevinpapst
Copy link
Member

Ah Interesting. So for me the rate was always bigger than 0, so it always showed up.
I wonder why I added that check...
Anyway, next release has the changed check for != 0 - fixed by kimai/kimai#4609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants