[bugreport]: Scoreboard does not update

[DSeeLP]

Describe the bug

The method in that the scoreboard is declared is called but the scoreboard is not changing. i need to reconnect to apply the changes

Environment information

• Operating system: Windows 10
• Java-Version: 1.8
• Kelp-Core-Version: v.0.0.4
• Version-Implementation: 1.8

[PXAV]

Could you please provide the code for your sidebar as well as the snippet from which you call the update method?

[DSeeLP]

i don't call the update method but the code gets executed.

    @CreateSidebar(identifier = "", setOnJoin = true)
    public AnimatedSidebar defaultSidebar(Player player) {
        AnimatedSidebar sidebar = sidebarFactory.newAnimatedSidebar();
        //sidebar.withTitle(animationFactory.newStaticTextAnimation("§6\u2022§e\u25cf §eDunityGames"));
        sidebar.withTitle(animationFactory.newStaticTextAnimation("§e§lDunityGames"));
        sidebar.addComponent(componentFactory.simpleTextComponent("§8➜ §eBargeld§8").line(15));
        sidebar.addComponent(componentFactory.simpleTextComponent("§8 ➥ §7"+ Economy.getMoney(player.getUniqueId())+"$").line(14));
        sidebar.addComponent(componentFactory.emptyLineComponent(13));
        sidebar.addComponent(componentFactory.simpleTextComponent("§8➜ §eBank§8").line(12));
        sidebar.addComponent(componentFactory.simpleTextComponent("§8 ➥ §7"+ Economy.getBank(player.getUniqueId())+"$").line(11));

        return sidebar;
    }

[DSeeLP]

I set an breakpoint at AnimatedSidebar sidebar = sidebarFactory.newAnimatedSidebar(); and it was executed repeatedly

[PXAV]

But how should the Sidebar update if the update method is never called? Try assigning a real identifier to the sidebar and call the update method in order to update it without rejoining

EDIT: What do you mean by i don't call the update method the code is executed?? Is the code executed although you have never called the method?

[DSeeLP]

yes the code is always executed and i never called the method

[PXAV]

Could you try removing the breakpoint?

[DSeeLP]

when i replace the AnimatedSidebar with the SimpleSidebar the method isn't called always

[PXAV]

Ah ok now I get your point. Yes, if you choose AnimatedSidebar as sidebar type, Kelp calls the sidebar method in the given animation interval in order to send the title update to the player. In your case, this does not make much sense, because you have chosen a static title. Here is the corresponding code from the Kelp source code:

// load the sidebar for the player
AnimatedSidebar sidebar = (AnimatedSidebar) getSidebar(identifier, player);
Preconditions.checkNotNull(sidebar);

// update the state. If the state index it out of bounds, reset it to 0.
animationStates.put(player, animationStates.get(player) + 1);
if (state >= sidebar.maxStates() - 1) {
  this.animationStates.put(player, 0);
}

// finally update the title.
sidebar.updateTitleOnly(player, state);

But thank you very much for reporting this issue, when developing the sidebar system I did not think of possible side effects, which can occur when the entire sidebar method is called every few seconds (querying databases within the sidebar method for example would cause a huge server lag). I think I will have to change the design of sidebar creation and apply the same principle used in the command system, where specific attributes such as permission, etc. are set in a different method (onCommandRegister) so that the main command method does not have to be called multiple times.

I think for the future, sidebars will take a dedicated class or lambda class in order to avoid this problem. I'll try my best to fix this issue!

pxav.