Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS protocol in external links. #45

Merged
merged 1 commit into from Mar 20, 2015
Merged

Use HTTPS protocol in external links. #45

merged 1 commit into from Mar 20, 2015

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2015

These websites are capable of secure communication, and future technologies which require secure connections in major implementations (SPDY/HTTP2, Firefox, Chrome).

@ghost
Copy link
Author

ghost commented Mar 18, 2015

This does work for sharing a link to a gallery entry (from the Share icon in the top bar).


This doesn't seem to work for uploading images. The dialog box still says "http" and the link copied from it is also "http".

This also doesn't work for copying the direct image link for images shown in the gallery.

@Kennyc1012
Copy link
Owner

When uploading an image, the URL returned is from the API. You would need to do a replace of http with https, but I rather avoid doing that as it is altering the link.

@ghost
Copy link
Author

ghost commented Mar 19, 2015

Would there be a detriment to using a substitution on the scheme of the link? I can't really see one; it seems safe to s/^http:/https:/ since imgur only returns links to its own service (and since it would affect only http, nothing else).

Kennyc1012 added a commit that referenced this pull request Mar 20, 2015
Use HTTPS protocol in external links.
@Kennyc1012 Kennyc1012 merged commit e2d3b6b into Kennyc1012:development Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant