New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar placement #110
Comments
Are we sure about this? No other Handbook has this search in subnav. In fact, only plugins dir (no make.* sites) has it at this moment. |
Those are for DevHub though and use the DevHub subnav expand/collapse search field. I trust the judgement of @mapk though so I'd say let's roll with his recommendation (and it can be iterated on if needed later on) |
@zzap While I agree that some of the other sites don't have this yet... this is the direction we're moving toward. If we can implement this pattern for the search field, that would be great. Thanks for your help with this! |
I've added the code the same way it is added in plugins dir - appended to main menu as menu item. Nothing is styled yet because we're waiting for sass to get merged to master. For now it looks like this: Once we have sass in, I'll add styles and create pull request. |
Any search bar that pertains to the immediate section (Docs, or Plugins, or whatever) needs to be displayed in the subnav area.
Current Search field placement (sidebar)
Proposed Search field placement (see Plugins)
The text was updated successfully, but these errors were encountered: