Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar placement #110

Closed
mapk opened this issue Aug 8, 2017 · 5 comments
Closed

Search bar placement #110

mapk opened this issue Aug 8, 2017 · 5 comments
Assignees

Comments

@mapk
Copy link
Collaborator

mapk commented Aug 8, 2017

Any search bar that pertains to the immediate section (Docs, or Plugins, or whatever) needs to be displayed in the subnav area.

Current Search field placement (sidebar)

screen shot 2017-08-08 at 9 58 46 am

Proposed Search field placement (see Plugins)

screen shot 2017-08-08 at 9 57 28 am

@zzap zzap self-assigned this Aug 10, 2017
@zzap
Copy link
Member

zzap commented Aug 13, 2017

Are we sure about this? No other Handbook has this search in subnav. In fact, only plugins dir (no make.* sites) has it at this moment.

cc @mapk @Clorith @Kenshino

@Clorith
Copy link
Member

Clorith commented Aug 13, 2017

Those are for DevHub though and use the DevHub subnav expand/collapse search field.

I trust the judgement of @mapk though so I'd say let's roll with his recommendation (and it can be iterated on if needed later on)

@mapk
Copy link
Collaborator Author

mapk commented Aug 14, 2017

@zzap While I agree that some of the other sites don't have this yet... this is the direction we're moving toward. If we can implement this pattern for the search field, that would be great. Thanks for your help with this!

@zzap
Copy link
Member

zzap commented Aug 14, 2017

Sure, sure! I just wanted to make sure we're.. well, sure :)

@mapk @Clorith

@zzap
Copy link
Member

zzap commented Aug 14, 2017

I've added the code the same way it is added in plugins dir - appended to main menu as menu item. Nothing is styled yet because we're waiting for sass to get merged to master. For now it looks like this:

search

Once we have sass in, I'll add styles and create pull request.

This is commit

@zzap zzap added the blocked label Aug 14, 2017
@Clorith Clorith removed the blocked label Aug 15, 2017
@Clorith Clorith closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants