Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle update action for Gatsby preview #105

Closed
wants to merge 16 commits into from
Closed

Conversation

Simply007
Copy link
Contributor

@Simply007 Simply007 commented Jan 22, 2020

Motivation

Handle edit action in Kentico Kontent from gatsby preview custom element

Format of the request when the action is performed:

{
      message: {
        operation: "update" : string,
        elementCodenames: changedElementCodenames : <string>[],
        selectedLanguage: language: string
      },
      data: { : JSON
        response  // response items/CODE_NAME
      }
}

Internal link:

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 requested a review from makma January 22, 2020 13:54
@Simply007 Simply007 added this to In Progress in Support Gatsby Cloud Jan 23, 2020
@Simply007
Copy link
Contributor Author

TODO:

  • It is required to decide what to do with usedByContentItems property because if we want to keep it and implement edit - wee need to edit all affected linked items when rich text/linked items element is changed
  • Remove all TODO comments from preview.js

@Simply007
Copy link
Contributor Author

blocked by #108

@Simply007
Copy link
Contributor Author

Implementation will be done based on the vNext branch.
Closing this as deprecated.

@Simply007 Simply007 closed this Apr 9, 2020
@Simply007 Simply007 deleted the preview-update branch April 9, 2020 11:52
@Simply007 Simply007 moved this from Waiting to Closed in Support Gatsby Cloud Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant