Clean-up: avoid writing or using tests/data/test_factory* files

.gitignore

@@ -73,3 +73,4 @@ pyraf
 sandbox
 mastDownload
 .pytest_cache
+.vscode

lightkurve/search.py

@@ -900,8 +900,11 @@ def open(path_or_url, **kwargs):
         >>> tpf = open("mytpf.fits")  # doctest: +SKIP
     """
     # pass header into `detect_filetype()`
-    with fits.open(path_or_url) as temp:
-        filetype = detect_filetype(temp[0].header)
+    try:
+        with fits.open(path_or_url) as temp:
+            filetype = detect_filetype(temp[0].header)
+    except OSError:  # Raised if not a fits file ("Header missing END card")
+        filetype = None
 
     # if the filetype is recognized, instantiate a class of that name
     if filetype is not None:

lightkurve/tests/test_search.py

@@ -293,7 +293,7 @@ def test_open():
     assert(isinstance(tesstpf, TessTargetPixelFile))
     # Open should fail if the filetype is not recognized
     try:
-        open(os.path.join(PACKAGEDIR, "tests", "data", "test_factory0.fits"))
+        open(os.path.join(PACKAGEDIR, "data", "lightkurve.mplstyle"))
     except ValueError:
         pass
     # Can you instantiate with a path?

lightkurve/tests/test_targetpixelfile.py

@@ -346,15 +346,16 @@ def test_tpf_from_images():
 
         # Can we read in a list of file names or a list of HDUlists?
         hdus = []
+        tmpfile_names = []
         for idx, im in enumerate(images):
+            tmpfile = tempfile.NamedTemporaryFile(delete=False)
+            tmpfile_names.append(tmpfile.name)
             hdu = fits.HDUList([fits.PrimaryHDU(), im])
-            hdu.writeto(get_pkg_data_filename('data/test_factory{}.fits'.format(idx)), overwrite=True)
+            hdu.writeto(tmpfile.name)
             hdus.append(hdu)
 
-        fnames = [get_pkg_data_filename('data/test_factory{}.fits'.format(i)) for i in range(5)]
-
         # Should be able to run with a list of file names
-        tpf_fnames = KeplerTargetPixelFile.from_fits_images(fnames,
+        tpf_tmpfiles = KeplerTargetPixelFile.from_fits_images(tmpfile_names,
                                                             size=(3, 3),
                                                             position=SkyCoord(ra, dec, unit=(u.deg, u.deg)))
 
@@ -363,6 +364,10 @@ def test_tpf_from_images():
                                                           size=(3, 3),
                                                           position=SkyCoord(ra, dec, unit=(u.deg, u.deg)))
 
+        # Clean up the temporary files we created
+        for filename in tmpfile_names:
+            os.remove(filename)
+
 
 def test_tpf_wcs_from_images():
     """Test to see if tpf.from_fits_images() output a tpf with WCS in the header"""