Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw instead of original #15

Closed
delirehberi opened this issue Dec 10, 2018 · 1 comment
Closed

Raw instead of original #15

delirehberi opened this issue Dec 10, 2018 · 1 comment
Assignees
@delirehberi @andrei-popa88
Labels
enhancement New feature or request

Comments

@delirehberi
Copy link

Why you don't use $x->query()->raw() instead of $x->query()->original().
i think it's more familiar for developers.
@andrei-popa88 andrei-popa88 reopened this Dec 10, 2018
@andrei-popa88
Copy link
Owner

andrei-popa88 commented Dec 10, 2018 •
edited
Loading

Agreed. raw() fits the semantics of the situation a whole lot better.

See commit

And I've also replaced some build*() functions with raw().

See commit

If you're satisfied with the new functionality mark the issue as closed, else add more suggestions 👍

@andrei-popa88 andrei-popa88 added the enhancement New feature or request label Dec 10, 2018
JunkyPic added a commit that referenced this issue Dec 10, 2018
@JunkyPic
#15 replaced build*() functions with raw() in Builder\Bags
c0b7e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delirehberi delirehberi

@andrei-popa88 andrei-popa88

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delirehberi @andrei-popa88