Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerbalism isn't aware of ODFC #508

Closed
zer0Kerbal opened this issue Sep 13, 2019 · 1 comment
Closed

Kerbalism isn't aware of ODFC #508

zer0Kerbal opened this issue Sep 13, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@zer0Kerbal
Copy link

zer0Kerbal/OnDemandFuelCells#44

All the functions of ODFC work with Kerbalism. However, the menu item for the fuel cells doesn't change status to "on".

https://imgur.com/a/XDd6JhD

@SirMortimer
Copy link
Contributor

Kerbalism has that feature pretty much built-in, although not that complex:

  1. go to the kerbalism automation UI
  2. switch to the POWER LOW script, set it to turn the fuel cell on
  3. switch to the POWER HIGH script, set it to turn the fuel cell off
  4. (optional) switch to the IN SUNLIGHT script, set it to turn the fuel cell off

That said, any automation that triggers things based on resource levels is very prone to cause havoc when you're time warping extremely fast. Which is why fuel cells tend to only tricle out just as much power as is neede while they're turned on.

Kerbalisms UI is not as fancy (like the collapse thing in the PAW!) and you can't configure what exactly "POWER LOW" means, but it works, and most importantly, it works on unloaded vessels. I didn't see any code in ODFC that even looks like it might handle background simulation.

Long story short, we can't support it, especially since we pretty much have the same functionality. Maybe this will change once #504 is implemented, but until then we're probably not going to integrate the additional functionality of fuel cells that ODFC adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants