Implement getVideo() for movie & tv show, season, episode #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It's useless to export AssetResolver class, so AssetQuality enum is moved to model directory and exported seperately. And also don't export gender-resolver as all gender ids are pre-resolved here. * Change min dart-sdk requirement to 2.1.0, and remove not needed import 'dart:async' Signed-off-by: Akash Mondal <a98mondal@gmail.com>
|
Everything look good, please increment the versions in pubspec and changelog and it is good to go. |
* This helps in changing the page number without changing Settings Signed-off-by: Akash Mondal <a98mondal@gmail.com>
* Remove all explicit initialization of default query parameters values, and keep them null if not passed by user. And remove the null values while building URI. tmdb API is smart enough to decide the default value for the unspecified parameters. Signed-off-by: Akash Mondal <a98mondal@gmail.com>
Signed-off-by: Akash Mondal <a98mondal@gmail.com>
|
I have tested these commits. And almost everything seems to be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useless to export AssetResolver class, so AssetQuality
enum is moved to model directory and exported seperately.
And also don't export gender-resolver as all gender ids are
pre-resolved here.
Change min dart-sdk requirement to 2.1.0, and remove not
needed import 'dart:async'
Signed-off-by: Akash Mondal a98mondal@gmail.com