Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tag to not associate itself with a specific Image #33

Open
Kevin-Mok opened this issue Nov 28, 2017 · 1 comment
Open

Refactor Tag to not associate itself with a specific Image #33

Kevin-Mok opened this issue Nov 28, 2017 · 1 comment
Assignees
@Kevin-Mok
Labels
refactor

Comments

@Kevin-Mok
Copy link
Owner

Then, it could also store a list of Images using it, and the count could come from the individual Tag objects versus the ImageTagManager class.
@Kevin-Mok Kevin-Mok self-assigned this Nov 28, 2017
@Kevin-Mok
Copy link
Owner Author

It'll still work right now if we just delete the Image field from the Tag class, but many new Tag objects will still be created everywhere. @SaadK97 and I discussed this and came to the conclusion that the major benefit to this refactoring would be to simply have less Tag objects in memory, but this isn't as important of an issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kevin-Mok Kevin-Mok

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kevin-Mok