Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA #15

Closed
mente371 opened this issue May 18, 2017 · 2 comments
Closed

PCA #15

mente371 opened this issue May 18, 2017 · 2 comments

Comments

@mente371
Copy link

mente371 commented May 18, 2017

i) Your library is great.
ii) In the function "getReducedBasisVectorSet(_ data: MLDataSet)",
at the end when you create the basisVectors matrice, should it not be
basisVectors[(vector * initialDimension) + column] = vTranspose[vector + (column * initialDimension)]
instead of
basisVectors[(vector * reducedDimension) + column] = vTranspose[vector + (column * initialDimension)]
?

@KevinCoble
Copy link
Owner

i) Thanks! It will be great to see what you do with it.

ii) I think you may be right. I am adding additional code to the XCTest file for PCA to verify the transformDataSet function that uses the basis vectors. I hope to get an update out in a couple of days.

@KevinCoble
Copy link
Owner

Updated a change today.
The new testing hopefully shows it working correctly for multiple basis vectors.

Thanks for finding the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants